Matthias Clasen [Tue, 4 Aug 2020 15:47:50 +0000 (15:47 +0000)]
Merge branch 'popoverflow' into 'master'
popover: Set overflow: hidden
Closes #3012
See merge request GNOME/gtk!2365
Matthias Clasen [Tue, 4 Aug 2020 15:47:36 +0000 (15:47 +0000)]
Merge branch 'a11y-crash' into 'master'
A11y crash
Closes #3014
See merge request GNOME/gtk!2364
Matthias Clasen [Tue, 4 Aug 2020 15:09:45 +0000 (11:09 -0400)]
popover: Set overflow: hidden
This keeps overlay scrollbars from wrecking our
nice rounded corners.
Fixes: #3012
Matthias Clasen [Tue, 4 Aug 2020 15:02:00 +0000 (11:02 -0400)]
a11y: Don't do unnecessary work
Only serialize all the attributes if we are actually
going to print them.
Matthias Clasen [Tue, 4 Aug 2020 15:00:32 +0000 (11:00 -0400)]
scrolledwindow: Fix a11y support code
This error was introduced by me in
971ee2d28a65b816050c
and causes a crash in the scrolling benchmark in gtk-demo.
Fixes: #3014
Florentina Mușat [Tue, 4 Aug 2020 11:23:33 +0000 (11:23 +0000)]
Update Romanian translation
Matthias Clasen [Tue, 4 Aug 2020 11:22:07 +0000 (11:22 +0000)]
Merge branch 'modern-doc-shooter' into 'master'
Modern doc shooter
See merge request GNOME/gtk!2363
Matthias Clasen [Tue, 4 Aug 2020 04:33:37 +0000 (00:33 -0400)]
docs: Add a gallery image for GtkDropDown
Matthias Clasen [Tue, 4 Aug 2020 04:25:35 +0000 (00:25 -0400)]
docs: Add a gallery image for GtkEditableLabel
Matthias Clasen [Tue, 4 Aug 2020 04:16:22 +0000 (00:16 -0400)]
docs: Add gallery image for GtkPasswordEntry
Matthias Clasen [Tue, 4 Aug 2020 04:14:17 +0000 (00:14 -0400)]
docs: Avoid focus in gallery images
Seeing focus rectangles and selections in these
images is a distraction, and we used to avoid it.
Bring that back.
Matthias Clasen [Tue, 4 Aug 2020 04:00:47 +0000 (00:00 -0400)]
docs: Improve the gallery image for scales
Matthias Clasen [Tue, 4 Aug 2020 03:42:27 +0000 (23:42 -0400)]
docs: Add gallery images for some more widgets
This adds GtkPicture, GtkVideo, GtkMediaControls.
Matthias Clasen [Tue, 4 Aug 2020 03:41:49 +0000 (23:41 -0400)]
docs: Regenerate widget gallery images
Matthias Clasen [Tue, 4 Aug 2020 01:09:54 +0000 (21:09 -0400)]
docs: Redo the doc shooter code
Steal snapshotting code from the reftests to
make this work again.
Other changes here: catch up with container removal.
Matthias Clasen [Tue, 4 Aug 2020 03:47:13 +0000 (03:47 +0000)]
Merge branch 'pagesetup-leftover' into 'master'
Pagesetup leftover
See merge request GNOME/gtk!2362
Matthias Clasen [Tue, 4 Aug 2020 00:35:40 +0000 (00:35 +0000)]
Merge branch 'doc-links' into 'master'
Doc links
See merge request GNOME/gtk!2361
Matthias Clasen [Tue, 4 Aug 2020 00:23:59 +0000 (20:23 -0400)]
pagesetupdialog: Fix leftover tree model code
This was overlooked when the rest of the dialog
was ported to use list models.
Matthias Clasen [Mon, 3 Aug 2020 22:41:36 +0000 (18:41 -0400)]
docs: Tweak documentation for list widgets
Fix numerous cases of : vs :: for signal references,
add some more details here and there.
Matthias Clasen [Mon, 3 Aug 2020 21:42:05 +0000 (17:42 -0400)]
docs: Unify docs around incremental operations
Sync up the wording around incremental filtering
and sorting to be more similar.
Matthias Clasen [Mon, 3 Aug 2020 21:18:07 +0000 (17:18 -0400)]
docs: Fix signal references
It is :: for signals, : for properties, | for actions.
Matthias Clasen [Mon, 3 Aug 2020 21:17:56 +0000 (17:17 -0400)]
docs: Fix typos
Matthias Clasen [Mon, 3 Aug 2020 20:53:44 +0000 (16:53 -0400)]
docs: Tell pandoc we need Docbook4
gtk-doc assumes Docbook4, with <ulink> and so on.
Without this, all the links in markdown are converted
to <link xlink:href=...> and then lost in the docbook->html
conversion.
Matthias Clasen [Mon, 3 Aug 2020 20:53:32 +0000 (16:53 -0400)]
docs: Fix a typo
Yuri Chornoivan [Mon, 3 Aug 2020 17:02:11 +0000 (17:02 +0000)]
Update Ukrainian translation
Matthias Clasen [Mon, 3 Aug 2020 16:22:19 +0000 (16:22 +0000)]
Merge branch 'patch-1' into 'master'
show: remove obsolete comment
See merge request GNOME/gtk!2359
Alex [Mon, 3 Aug 2020 15:36:36 +0000 (15:36 +0000)]
show: remove obsolete comment
g_app_info_launch_default_for_uri supports x-scheme-handler directly since at least 2.27.1, released almost 10 years ago.
Link: https://bugzilla.gnome.org/show_bug.cgi?id=631410
Link: https://gitlab.gnome.org/GNOME/glib/-/commit/9b262f1c5fe5a6fd879f17cd7b80d8c54e33d80c
Matthias Clasen [Mon, 3 Aug 2020 12:28:20 +0000 (12:28 +0000)]
Merge branch 'treeview-editing' into 'master'
treeview: Don't react to clicks on cell editables
Closes #3008
See merge request GNOME/gtk!2358
Matthias Clasen [Mon, 3 Aug 2020 11:49:31 +0000 (07:49 -0400)]
treeview: Don't react to clicks on cell editables
We need to let these pass through, otherwise we
interfere with the entries that are used for editing.
Fixes: #3008
Matthias Clasen [Mon, 3 Aug 2020 11:09:03 +0000 (11:09 +0000)]
Merge branch 'filechoosernative-docs' into 'master'
docs: Introspect GtkFileChooserNative info
Closes #2799
See merge request GNOME/gtk!2357
Matthias Clasen [Mon, 3 Aug 2020 04:13:10 +0000 (00:13 -0400)]
docs: Introspect GtkFileChooserNative info
We were missing gtk_file_chooser_native_get_type
in gtk4.types.in, causing introspected info to not
be included.
Fixes: #2799
Matthias Clasen [Mon, 3 Aug 2020 03:30:59 +0000 (03:30 +0000)]
Merge branch 'applaunch-warning' into 'master'
x11: Ignore stray DestroyNotify events
Closes #3006
See merge request GNOME/gtk!2355
Matthias Clasen [Mon, 3 Aug 2020 02:43:48 +0000 (22:43 -0400)]
x11: Ignore stray DestroyNotify events
There's no use in making a delete event with a
NULL surface. Just ignore such events.
Fixes: #3006
Matthias Clasen [Mon, 3 Aug 2020 02:19:01 +0000 (02:19 +0000)]
Merge branch 'fishbowl-crash' into 'master'
Fishbowl crash
Closes #2996 and #3003
See merge request GNOME/gtk!2352
Matthias Clasen [Mon, 3 Aug 2020 02:18:41 +0000 (02:18 +0000)]
Merge branch 'search-demo-fixes' into 'master'
Search demo fixes
Closes #3004
See merge request GNOME/gtk!2354
Matthias Clasen [Mon, 3 Aug 2020 02:18:28 +0000 (02:18 +0000)]
Merge branch 'tagged-entry-demo' into 'master'
gtk-demo: Simplify the tagged entry demo
Closes #3005
See merge request GNOME/gtk!2353
Matthias Clasen [Mon, 3 Aug 2020 01:53:59 +0000 (21:53 -0400)]
gtk-demo: Fix cleanup of search entry demo
We can't use the ::destroy signal anymore; use
a weak ref instead, and make ensure the entry
stays around long enough for us to finish the
cleanup.
Fixes: #3004
Matthias Clasen [Mon, 3 Aug 2020 01:46:44 +0000 (21:46 -0400)]
gtk-demo: Make search progress visible again
Set a progress fraction, so that the pulsing progress
in the search entry demo is actually visible.
Matthias Clasen [Mon, 3 Aug 2020 01:40:51 +0000 (01:40 +0000)]
Merge branch 'font-explorer-crash' into 'master'
gtk-demo: Avoid invalid OpenType feature tags
Closes #2962
See merge request GNOME/gtk!2351
Matthias Clasen [Mon, 3 Aug 2020 01:40:43 +0000 (01:40 +0000)]
Merge branch 'emoji-insert-fix' into 'master'
textview: Make insert-emoji replace the selection
Closes #2996
See merge request GNOME/gtk!2350
Matthias Clasen [Mon, 3 Aug 2020 01:38:25 +0000 (21:38 -0400)]
gtk-demo: Simplify the tagged entry demo
No need for an intermediate box widget here;
we can just use a box layout. As a side-effect,
this fixes the theme to apply to the selection.
Fixes: #3005
Matthias Clasen [Mon, 3 Aug 2020 01:27:03 +0000 (21:27 -0400)]
gdk: Fix gdk_surface_get_layout_monitor
We are determining the monitor by maximizing the
intersection; that only works if our rectangle
is not empty.
Fixes: #3003
Matthias Clasen [Mon, 3 Aug 2020 01:11:30 +0000 (21:11 -0400)]
gtk-demo: Avoid invalid OpenType feature tags
ss00 doesn't exist, and we use xxxx as placeholder
for 'default' choices in alternatives. Add a warning
in case we run across invalid OpenType feature tags
in fonts.
Fixes: #2962
Matthias Clasen [Mon, 3 Aug 2020 00:48:14 +0000 (20:48 -0400)]
textview: Make insert-emoji replace the selection
This is the expected behavior, and matches what
GtkText does.
Fixes: #2996
Matthias Clasen [Mon, 3 Aug 2020 00:23:28 +0000 (00:23 +0000)]
Merge branch 'filechooser-completions' into 'master'
filechooser: Prevent over-eager completions
Closes #2995
See merge request GNOME/gtk!2347
Matthias Clasen [Mon, 3 Aug 2020 00:23:13 +0000 (00:23 +0000)]
Merge branch 'wip/chergert/gtk4-textview-fix-selections' into 'master'
textlinedisplaycache: short-circuit y_range invalidation
Closes #2975
See merge request GNOME/gtk!2348
Matthias Clasen [Mon, 3 Aug 2020 00:19:43 +0000 (00:19 +0000)]
Merge branch 'fix-win32-ci' into 'master'
ci: Don't use --werror for the win32 build
See merge request GNOME/gtk!2349
Matthias Clasen [Sun, 2 Aug 2020 23:59:25 +0000 (19:59 -0400)]
ci: Don't use --werror for the win32 build
This leads to warnings from the glib win32 build
failing our ci. Only use werror for gtk itself.
Christian Hergert [Sun, 2 Aug 2020 23:35:50 +0000 (16:35 -0700)]
textlinedisplaycache: short-circuit y_range invalidation
If we have a y==-1 then we are generally invalidating the whole textview.
For this case, we can just discard the entire GtkTextLineDisplay cache.
Fixes #2975
Matthias Clasen [Sun, 2 Aug 2020 23:18:11 +0000 (19:18 -0400)]
filechooser: Prevent over-eager completions
We don't want the completions to pop up after we call
gtk_file_chooser_set_current_name(). This used to be
handled by gtk_entry_set_text() blocking the completion
signal handler. We don't have that anymore, so block
popup completion around the call to gtk_editable_set_text()
instead.
Fixes: #2995
Matthias Clasen [Sun, 2 Aug 2020 23:17:40 +0000 (23:17 +0000)]
Merge branch 'grid-api' into 'master'
grid layout: Rename some properties
Closes #2967
See merge request GNOME/gtk!2345
Matthias Clasen [Sun, 2 Aug 2020 19:10:18 +0000 (15:10 -0400)]
builder-tool: Rewrite top/left-attach
Rewrite the GtkGrid:top/left-attach child properties
to the GtkGridLayoutChild:row/column layout properties.
Update expected test output to match.
Matthias Clasen [Sun, 2 Aug 2020 18:13:14 +0000 (14:13 -0400)]
grid layout: Rename some properties
Rename GtkGridLayoutChild:left-attach/top-attach to
GtkGridLayoutChild:column/row. Update all users.
Fixes: #2967
Matthias Clasen [Sun, 2 Aug 2020 21:55:43 +0000 (21:55 +0000)]
Merge branch 'fix-textiter-tests' into 'master'
textbuffer: Fix a test failure
See merge request GNOME/gtk!2346
Matthias Clasen [Sun, 2 Aug 2020 21:23:26 +0000 (17:23 -0400)]
textbuffer: Fix a test failure
The previous change to gtktextbuffer.c was breaking
the textiter testcase.
Matthias Clasen [Sun, 2 Aug 2020 17:54:06 +0000 (13:54 -0400)]
textbuffer: Be careful with tags when copying
We can only insert tags in the buffer if they come
from the same GtkTextTagTable as the buffer uses.
If that is not the case, paste the text without tags.
Fixes: #2991
Matthias Clasen [Sun, 2 Aug 2020 17:45:30 +0000 (17:45 +0000)]
Merge branch 'text-drag-select' into 'master'
textview: Only claim the event when appropriate
Closes #2999
See merge request GNOME/gtk!2344
Matthias Clasen [Sun, 2 Aug 2020 17:42:22 +0000 (17:42 +0000)]
Merge branch 'fallback-menu-critical' into 'master'
popovermenu: Avoid a critical
Closes #2998
See merge request GNOME/gtk!2343
Matthias Clasen [Sun, 2 Aug 2020 17:31:15 +0000 (13:31 -0400)]
textview: Only claim the event when appropriate
Don't claim the event unconditionally for the click gesture,
since we may want to start a drag selection.
Fixes: #2999
Matthias Clasen [Sun, 2 Aug 2020 17:09:00 +0000 (13:09 -0400)]
popovermenu: Avoid a critical
While we guarantee that the widget that a controller
is attached to stays around while it is handling an event,
the same is not true for the root that the widget belongs
to. In corner cases (such as clicking "Close" in the
fallback window menu), it may already be gone.
Avoid a critical in that case.
Fixes: #2998
Matthias Clasen [Sun, 2 Aug 2020 16:40:12 +0000 (16:40 +0000)]
Merge branch 'selectable-label-draw' into 'master'
label: Redraw when focus changes
See merge request GNOME/gtk!2342
Matthias Clasen [Sun, 2 Aug 2020 16:39:59 +0000 (16:39 +0000)]
Merge branch 'linked-button-fixes' into 'master'
Adwaita: Add linked styling for particular button widgets
Closes #2939 and #1903
See merge request GNOME/gtk!2339
Matthias Clasen [Sun, 2 Aug 2020 16:25:50 +0000 (16:25 +0000)]
Merge branch 'controllers-list' into 'master'
Controllers list
See merge request GNOME/gtk!2341
Matthias Clasen [Sun, 2 Aug 2020 15:24:27 +0000 (11:24 -0400)]
label: Redraw when focus changes
When focus changes in a selectable label, we need to
redraw to make the text caret (dis)appear.
Matthias Clasen [Sun, 2 Aug 2020 16:00:46 +0000 (12:00 -0400)]
Go back to keeping a list of event controllers
This reverts
4b9e5304cc1f675d2. It caused a number of regressions,
such as event controller ordering changes.
Matthias Clasen [Sun, 2 Aug 2020 15:54:29 +0000 (11:54 -0400)]
Revert "Add gtk_widget_prepend_controller"
This reverts commit
692cc42e1023ec439d2fa1a0b9456e8cbfe1cec8.
Matthias Clasen [Sun, 2 Aug 2020 15:54:03 +0000 (11:54 -0400)]
Revert "entry completion: Make keynav work again"
This reverts commit
53a30eaa12e44a2ee5da7c9bc9a23a8bfeb733dc.
Matthias Clasen [Sun, 2 Aug 2020 15:05:17 +0000 (15:05 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
shortcutswindow: Clear search entry on unmap
Closes #2981
See merge request GNOME/gtk!2340
Matthias Clasen [Sun, 2 Aug 2020 13:33:52 +0000 (09:33 -0400)]
shortcutswindow: Clear search entry on unmap
Otherwise, the search term will linger around until
somebody clicks the search button again.
Fixes: #2981
Piotr Drąg [Sun, 2 Aug 2020 12:36:18 +0000 (14:36 +0200)]
Update Polish translation
nana-4 [Sun, 2 Aug 2020 09:48:54 +0000 (18:48 +0900)]
Adwaita: Add linked styling for particular button widgets
Those button widgets need some special linked styling like what
combobox has.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/1903
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2939
nana-4 [Sun, 2 Aug 2020 09:26:40 +0000 (18:26 +0900)]
appchooserbutton: Set a CSS name
Otherwise it has a CSS name "widget".
Matthias Clasen [Sun, 2 Aug 2020 03:47:22 +0000 (03:47 +0000)]
Merge branch 'ci-installed-tests' into 'master'
Run installed tests in ci
Closes #2966
See merge request GNOME/gtk!2335
Matthias Clasen [Sun, 2 Aug 2020 03:25:33 +0000 (03:25 +0000)]
Merge branch 'inspector-device-details' into 'master'
inspector: Introspect enum values
See merge request GNOME/gtk!2338
Matthias Clasen [Sun, 2 Aug 2020 02:42:25 +0000 (22:42 -0400)]
cups: Don't emit a warning if we can't talk to avahi
The g_warning in this case makes the templates test
fail if it can't connect to the system bus (as is the
case for running installed tests in ci).
Matthias Clasen [Sun, 2 Aug 2020 02:30:06 +0000 (22:30 -0400)]
installed-tests: Fix the icontheme test
We forgot to install some of the icons, causing
the test to fail.
Matthias Clasen [Sun, 2 Aug 2020 01:25:29 +0000 (21:25 -0400)]
ci: Add a build that runs installed tests
This will hopefully prevent regressions in
installed-tests.
Matthias Clasen [Sun, 2 Aug 2020 03:05:24 +0000 (23:05 -0400)]
inspector: Introspect enum values
Stop hardcoding arrays with names for enum values.
This has bitten us repeatedly as these enums were
changed around; time to stop doing it.
Matthias Clasen [Sun, 2 Aug 2020 02:45:53 +0000 (02:45 +0000)]
Merge branch 'label-copy-link-fix' into 'master'
Label copy link fix
See merge request GNOME/gtk!2337
Matthias Clasen [Sun, 2 Aug 2020 02:45:30 +0000 (02:45 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
testsuite: Fix installed tests
Closes #2966
See merge request GNOME/gtk!2336
Matthias Clasen [Sun, 2 Aug 2020 01:39:02 +0000 (21:39 -0400)]
ci: Use newer fedora image
v22 adds gnome-desktop-testing-runner and enables sudo.
Matthias Clasen [Sun, 2 Aug 2020 02:11:07 +0000 (22:11 -0400)]
ci: Enable sudo in the image
This is needed so we can install what we built.
Matthias Clasen [Sun, 2 Aug 2020 01:26:35 +0000 (21:26 -0400)]
ci: Add gnome-desktop-testing to images
Matthias Clasen [Sun, 2 Aug 2020 01:23:34 +0000 (21:23 -0400)]
testsuite: Fix installed tests
This broken recently, when we converted the tests
array to a dictionary.
Fixes: #2966
Matthias Clasen [Sun, 2 Aug 2020 01:23:34 +0000 (21:23 -0400)]
testsuite: Fix installed tests
This broken recently, when we converted the tests
array to a dictionary.
Fixes: #2966
Matthias Clasen [Sun, 2 Aug 2020 02:03:06 +0000 (22:03 -0400)]
menusectionbox: Avoid a critical warning
The popover may already be gone when the item
is activated. Don't trigger a critical in that
case.
Related: #2986
Matthias Clasen [Sun, 2 Aug 2020 02:01:52 +0000 (22:01 -0400)]
label: Be more selective when selecting on focus-in
We don't want to select on focus-in when the focus
comes from a child. The case where this does harm
is when you activate copy or paste actions from the
context menu. We close the menu before triggering the
action, and if that causes the text in the label to
be selected, unexpected things happen, since the action
applies to the current selection.
This is the equivalent of
cd9f5733b3e354301f2 for GtkLabel.
Matthias Clasen [Sun, 2 Aug 2020 01:30:31 +0000 (01:30 +0000)]
Merge branch 'glib-build-fix' into 'master'
togglebutton: Don't crash on click
See merge request GNOME/gtk!2334
Matthias Clasen [Sun, 2 Aug 2020 00:09:05 +0000 (20:09 -0400)]
togglebutton: Don't crash on click
The code used to do
if (parent_class->clicked)
parent_class->clicked (...)
That is pointless because the parent_class never changes,
so there' no need for that if and commit
415946eb0f3b76ba25
took it out. Unfortunately, p arent_class->clicked is NULL
though, so the whole call needs to go.
Matthias Clasen [Sat, 1 Aug 2020 23:58:04 +0000 (23:58 +0000)]
Merge branch 'wip/baedert/for-master' into 'master'
Wip/baedert/for master
Closes #2980, #2974, #2949, and #2766
See merge request GNOME/gtk!2333
Timm Bäder [Sat, 1 Aug 2020 18:00:13 +0000 (20:00 +0200)]
Fix and improve various code samples
Timm Bäder [Sat, 1 Aug 2020 17:30:31 +0000 (19:30 +0200)]
aboutdialog: Fix a code sample
gdk_texture_new_from_file takes a GFile these days.
Timm Bäder [Sat, 1 Aug 2020 17:24:54 +0000 (19:24 +0200)]
togglebutton: Modernice source file
Make this a little less ancient looking.
Timm Bäder [Sat, 1 Aug 2020 13:34:59 +0000 (15:34 +0200)]
Avoid refering to old GtkContainer API in the docs
Timm Bäder [Sat, 1 Aug 2020 13:34:07 +0000 (15:34 +0200)]
button: Use g_object_notify_by_pspec()
Timm Bäder [Sat, 1 Aug 2020 13:27:13 +0000 (15:27 +0200)]
stack: Allow NULL names
Does this work?
Timm Bäder [Sat, 1 Aug 2020 13:26:53 +0000 (15:26 +0200)]
stack: Only compare page names if the new page has one
Timm Bäder [Sat, 1 Aug 2020 13:26:28 +0000 (15:26 +0200)]
listbox: Add _append
To have easy replacement API for gtk_container_add.
Timm Bäder [Sat, 1 Aug 2020 08:31:53 +0000 (10:31 +0200)]
adwaita: Reset popover background in backdrop
Otherwise it inherits the generic background color from .background
Fixes #2766
Timm Bäder [Sat, 1 Aug 2020 08:31:38 +0000 (10:31 +0200)]
popover: Use gtk_widget_add_css_class